SEGUC17 / mean_squad

The repo for our Software Engineering course.
0 stars 3 forks source link

Client Name can be edited to be undefined #219

Open Omarkojak opened 7 years ago

Omarkojak commented 7 years ago

1. Severity: High 2. Reported by: Omar kojak (Ashraf) 3. Description: The client name can be changed to be undefined however it is required in the signup form 4. Steps to reproduce the issue:

1) Signup to the system as a client (Name is required) 2) Confirm your email and login 3) Go to your profile then edit info 4) don't enter a name in the name field 5) the post request will continue and the name will be changed to undefined (This will happen at the first edit form submission)

5. Expected result: Either handle it backend if the name is empty don't update the client name in the database or make the default of the form name field is the client's name and if he tried to make it empty generate an error that he cannot make such an action

screen shot 2017-05-01 at 1 53 44 pm
ameniawy commented 7 years ago

The severity has been changed to low, as the client name is only displayed to the logged in client owning this profile, its only a UX issue, the client name is not used anywhere in the backend.