search

SEL-Columbia / bamboo

Dynamic data analysis over the web. The logic to your data dashboards.
http://bamboo.io
BSD 3-Clause "New" or "Revised" License
157 stars 20 forks source link

reset endpoint doesn't allow an OPTIONS request #598

Closed larryweya closed 10 years ago

larryweya commented 10 years ago

While testing the reset endpoint with bamboo.js, the OPTIONS request returns a 404

larryweya commented 10 years ago

@pld Same applies to delete row and update row endpoints

pld commented 10 years ago

Looking through bamboo/config/routes.py it appears only a subset of endpoints accept an OPTIONS request (they're at the top).

Which endpoints should we allow options requests for? Should we allow options requests for all endpoints?

larryweya commented 10 years ago

I'm trying to figure out when an OPTIONS request is sent, both jquery and angular dont to do it on GET requests, however, angular sends one on POST requests.

These are the endpoints that I feel need an OPTIONS request at the moment:

pld commented 10 years ago

OK, will add those, is there any downside to adding it for all of the routes?

larryweya commented 10 years ago

I dont see a problem since bamboo doesn't require authentication at the moment I also dont see a security issue.

pld commented 10 years ago

I merged and deployed code that adds options for all routes, I don't think there are robust tests for it so not guaranteeing everything is OK. Can you check it out and let me know if this works for you?