search

SEL-Columbia / formhub

Mobile Data Collection made easy.
http://formhub.org
BSD 2-Clause "Simplified" License
259 stars 163 forks source link

Allow switching to google maps and satellite layers #227

Closed prabhasp closed 12 years ago

prabhasp commented 12 years ago

See Google Maps as a layer in leaflet; demo http://psha.org.ru/leaflet/bel.html code http://psha.org.ru/leaflet/Google.js discussion http://leaflet.uservoice.com/forums/150880-ideas-and-suggestions-for-leaflet/suggestions/2615505-google-maps-support-using-the-api-

pld commented 12 years ago

Wax has Google maps connector support, http://mapbox.com/wax/connector-g.html

It wasn't clear how to integrate this with leaflet but this may be a preferable/cleaner solution.

larryweya commented 12 years ago

I've tried this and it seems to be the reverse of what we want, instead of using leaflet to show a google map, its uses google maps to show leaflet/mapbox tiles on top of the google map.

larryweya commented 12 years ago

I've been looking deeper into this and I'm still not quite clear. If we use the wax connector, we end up with the Google Maps API onto which we can add our layers/filters etc. If we use leaflet I can't seem to get Google Maps to work properly (using the Google leaflet extension), the map only shows up if the Doctype declaration is removed.

My question is why do we want to use Google maps, if its for the satellite imagery perhaps we can look for an alternative source.

pld commented 12 years ago

OK, so that's not what we want. I guess it's expected that pulling Google maps tiles isn't straightforward, since Google might not encourage this.

That's a good question and I don't know the answer. Maybe we can just pull the Bing satellite imagery and be fine with that.

larryweya wrote:

I've been looking deeper into this and I'm still not quite clear. If we use the wax connector, we end up with the Google Maps API onto which we can add our layers/filters etc. If we use leaflet I can't seem to get Google Maps to work properly (using the Google leaflet extension), the map only shows up if the Doctype declaration is removed.

My question is why do we want to use Google maps, if its for the satellite imagery perhaps we can look for an alternative source.

Reply to this email directly or view it on GitHub: https://github.com/modilabs/formhub/issues/227#issuecomment-4519182

Peter Lubell-Doughtie http://www.helioid.com/

prabhasp commented 12 years ago

The reason for google tiles is that in some areas, it has much better data coverage than OSM does (roads, communities, etc.); including in some areas we work. Given a good-hearted effort to make it work and limited success, lets punt pulling in google maps for now then, and just pull in Bing satellite imagery.

On Thu, Mar 15, 2012 at 9:26 AM, Peter Lubell-Doughtie < reply@reply.github.com

wrote:

OK, so that's not what we want. I guess it's expected that pulling Google maps tiles isn't straightforward, since Google might not encourage this.

That's a good question and I don't know the answer. Maybe we can just pull the Bing satellite imagery and be fine with that.

larryweya wrote:

I've been looking deeper into this and I'm still not quite clear. If we use the wax connector, we end up with the Google Maps API onto which we can add our layers/filters etc. If we use leaflet I can't seem to get Google Maps to work properly (using the Google leaflet extension), the map only shows up if the Doctype declaration is removed.

My question is why do we want to use Google maps, if its for the satellite imagery perhaps we can look for an alternative source.

Reply to this email directly or view it on GitHub: https://github.com/modilabs/formhub/issues/227#issuecomment-4519182

Peter Lubell-Doughtie http://www.helioid.com/

Reply to this email directly or view it on GitHub: https://github.com/modilabs/formhub/issues/227#issuecomment-4519447

Prabhas Pokharel http://twitter.com/prabhasp Nepal mobile: +977 98137 91044 US mobile: +1 347 948 7654 skype/facebook/whatever: prabhasp

mberg commented 12 years ago

Here's a pull request for Bing satellites.

I agree let's not spend a lot more time on Google and work on the other features in this milestone.