search

SEL-Columbia / mopup-matcher

mopup-manager revamp
1 stars 0 forks source link

after matching behavior #6

Closed MartijnR closed 11 years ago

MartijnR commented 11 years ago

https://github.com/modilabs/mopup-manager/issues/10 @myf says: either gray out or retrieve the list again for NMIS and LGA

MartijnR commented 11 years ago

need to add class="matched" on table row ``` for matched items in table

myf commented 11 years ago

I have created a $rootScope.localMatch that has all the matched id from the history to the currently working on ones. check if the id is in localMatch, then gray it out.

prabhasp commented 11 years ago

gray it out, or remove? @rowo? i remember early discussions (which still make sense) saying remove, because that makes scanning the rest of the items easier by making it shorter. If we are worried about visibility, this should happen on the left side as well. Will tackle this, along with #16 in remove-facilities-after-matching.

myf commented 11 years ago

I suggest gray out. Since we have this fregging awesome search bar I've been having fun with it and it can shorten then list by a lot. It makes sense for the ta to see their progress. On Apr 29, 2013 6:22 AM, "prabhasp" notifications@github.com wrote:

gray it out, or remove? @rowo https://github.com/rowo? i remember early discussions (which still make sense) saying remove, because that makes scanning the rest of the items easier by making it shorter. If we are worried about visibility, this should happen on the left side as well. Will tackle this, along with #16https://github.com/modilabs/mopup-seed/issues/16in remove-facilities-after-matching.

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17159185 .

prabhasp commented 11 years ago

@rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

MartijnR commented 11 years ago

if we remove we can just do this in css as well (display: none) in the tr.matched rule

On Mon, Apr 29, 2013 at 9:08 AM, prabhasp notifications@github.com wrote:

@rowo https://github.com/rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172348 .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

myf commented 11 years ago

also i have all the matched ID in $rootScope.localMatch, use that to populate if you like

On Mon, Apr 29, 2013 at 11:12 AM, Martijn van de Rijdt < notifications@github.com> wrote:

if we remove we can just do this in css as well (display: none) in the tr.matched rule

On Mon, Apr 29, 2013 at 9:08 AM, prabhasp notifications@github.com wrote:

@rowo https://github.com/rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172348> .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172619 .

Have you ever imagined that you are standing on the EARTH?

myf commented 11 years ago

I am just concerned about putting those back in once the match is undone

On Mon, Apr 29, 2013 at 11:22 AM, Myf worldwidespirit@gmail.com wrote:

also i have all the matched ID in $rootScope.localMatch, use that to populate if you like

On Mon, Apr 29, 2013 at 11:12 AM, Martijn van de Rijdt < notifications@github.com> wrote:

if we remove we can just do this in css as well (display: none) in the tr.matched rule

On Mon, Apr 29, 2013 at 9:08 AM, prabhasp notifications@github.com wrote:

@rowo https://github.com/rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172348> .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172619 .

Have you ever imagined that you are standing on the EARTH?

Have you ever imagined that you are standing on the EARTH?

MartijnR commented 11 years ago

that's why just using css is a nice safe solution

On Mon, Apr 29, 2013 at 9:23 AM, Myf Ma notifications@github.com wrote:

I am just concerned about putting those back in once the match is undone

On Mon, Apr 29, 2013 at 11:22 AM, Myf worldwidespirit@gmail.com wrote:

also i have all the matched ID in $rootScope.localMatch, use that to populate if you like

On Mon, Apr 29, 2013 at 11:12 AM, Martijn van de Rijdt < notifications@github.com> wrote:

if we remove we can just do this in css as well (display: none) in the tr.matched rule

On Mon, Apr 29, 2013 at 9:08 AM, prabhasp notifications@github.com wrote:

@rowo https://github.com/rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172348> .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172619> .

Have you ever imagined that you are standing on the EARTH?

Have you ever imagined that you are standing on the EARTH?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17173339 .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

rowo commented 11 years ago

I agree with the initial reasoning of removing the rows if we can make it apparent they are joining the Matched List to the right. It should reduce the two main lists to make it easier to navigate.

Barring a Mac OS X style animations where the rows literally animate over to the matched list, if we can easily just fade out the rows on the main lists while fade in the rows to the Matched List, I'd say we do that.

On Mon, Apr 29, 2013 at 11:12 AM, Martijn van de Rijdt < notifications@github.com> wrote:

if we remove we can just do this in css as well (display: none) in the tr.matched rule

On Mon, Apr 29, 2013 at 9:08 AM, prabhasp notifications@github.com wrote:

@rowo https://github.com/rowo Can you provide the deciding vote? I still favor removal. Also, what should happen to the selected / starred item on the top menu, when "match" is selected. Automatically move down one? Something else?

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172348> .

Enketo http://enketo.org | LinkedIn http://www.linkedin.com/in/martijnvanderijdt/ | GitHubhttps://github.com/MartijnR

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17172619 .

MartijnR commented 11 years ago

Animation is a big pain (in Angular) but not so important for now I guess, so I'll just hide it without animation.

After a match, should a new facility be selected automatically? The first unmatched in the top table e.g.?

rowo commented 11 years ago

Okay. no animation is okay. Hope it is obvious.

I would say the next facility should be selected automatically as you said.

On Mon, Apr 29, 2013 at 5:05 PM, Martijn van de Rijdt < notifications@github.com> wrote:

Animation is a big pain (in Angular) but not so important for now I guess, so I'll just hide it without animation.

After a match, should a new facility be selected automatically? The first unmatched in the top table e.g.?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/6#issuecomment-17194330 .

prabhasp commented 11 years ago

Close this for launch by just de-selecting the previously selected LGA from the NMIS list.