SEL-Columbia / mopup-matcher

mopup-manager revamp
1 stars 0 forks source link

Add "Facility Not Matchable" functionality #61

Closed rowo closed 11 years ago

rowo commented 11 years ago

Hi all, @schafik mentioned the TA's and Maduka requesting the ability to mark a facility as "no match" and provide a reason. @prabhasp said we should try to do it. The quickest way I can see doing it is greying out a line rather than creating another list on the right. I attached some files to illustrate how it could work:

  1. When you mouseover or select a row, a button appears on the right (the minus).
  2. Clicking on the minus triggers a popup, with a list of reasons (need the list from @schafik). These should probably be radio buttons. They shouldn't be forced to select one, and hopefully 'Other' won't need a text box if we get the list of options right. When you press "OK", the row greys out. I guess it can still be included in search results without having too much impact.
  3. When you mouseover a greyed out row, the text becomes slightly darker so you can read it, and the green plus button appears on the right that activates the facility again if you push it.

nomatch-01 nomatch-02 nomatch-03

prabhasp commented 11 years ago

@rowo You also show a facility greyed out on the bottom list. How does that work...?

rowo commented 11 years ago

My mistake, facility list doesn't change with this functionality. Only Baseline facilities can be marked. Does it make sense for Facility List rows to also be marked?

On May 1, 2013, at 8:04 PM, prabhasp notifications@github.com wrote:

@rowo You also show a facility greyed out on the bottom list. How does that work...?

— Reply to this email directly or view it on GitHub.

prabhasp commented 11 years ago

Leave that to salah, with a preference to keep it simple and not have this if possible. This is what the original report a problem button was for. On May 1, 2013 8:17 PM, "Roger W." notifications@github.com wrote:

My mistake, facility list doesn't change with this functionality. Only Baseline facilities can be marked. Does it make sense for Facility List rows to also be marked?

On May 1, 2013, at 8:04 PM, prabhasp notifications@github.com wrote:

@rowo You also show a facility greyed out on the bottom list. How does that work...?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17314242 .

schafik commented 11 years ago

Yes, only the baseline facilities should have this "facility not matchable" functionality. I am trying to get the list confirmed by Chinedu... will get it you you guys by the end of today.

On Thu, May 2, 2013 at 1:47 AM, prabhasp notifications@github.com wrote:

Leave that to salah, with a preference to keep it simple and not have this if possible. This is what the original report a problem button was for. On May 1, 2013 8:17 PM, "Roger W." notifications@github.com wrote:

My mistake, facility list doesn't change with this functionality. Only Baseline facilities can be marked. Does it make sense for Facility List rows to also be marked?

On May 1, 2013, at 8:04 PM, prabhasp notifications@github.com wrote:

@rowo You also show a facility greyed out on the bottom list. How does that work...?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/modilabs/mopup-seed/issues/61#issuecomment-17314242> .

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17315081 .

MartijnR commented 11 years ago

radio buttons (one value) or checkboxes (multiple values)?

schafik commented 11 years ago

radio.

On Fri, May 3, 2013 at 3:44 PM, Martijn van de Rijdt < notifications@github.com> wrote:

radio buttons (one value) or checkboxes (multiple values)?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17397864 .

prabhasp commented 11 years ago

One value. Unless @schafik thinks otherwise. On May 3, 2013 10:44 PM, "Martijn van de Rijdt" notifications@github.com wrote:

radio buttons (one value) or checkboxes (multiple values)?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17397864 .

rowo commented 11 years ago

I'd say checkboxes for now. Did Salah send out a list f reasons yet?

On May 3, 2013, at 10:44 AM, Martijn van de Rijdt notifications@github.com wrote:

radio buttons (one value) or checkboxes (multiple values)?

— Reply to this email directly or view it on GitHub.

MartijnR commented 11 years ago

:)

schafik commented 11 years ago

yup, I put it on #52. Sorry about the confusion.

-Not a registered facility: no longer in use and/or not functional

-Not a registered facility: facility no longer exists

-Duplicate facility

-Other

On Fri, May 3, 2013 at 3:49 PM, Martijn van de Rijdt < notifications@github.com> wrote:

:)

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17398162 .

rowo commented 11 years ago

I actually did mean radio buttons :)

MartijnR commented 11 years ago

Ha!

MartijnR commented 11 years ago

@schafik: add "Other" as 4th option?

schafik commented 11 years ago

Yup other as a 4th option that they can write a specific explanation for.

On May 3, 2013, at 6:58 PM, Martijn van de Rijdt notifications@github.com wrote:

@schafik https://github.com/schafik: add "Other" as 4th option?

— Reply to this email directly or view it on GitHubhttps://github.com/modilabs/mopup-seed/issues/61#issuecomment-17408867 .

MartijnR commented 11 years ago

https://github.com/modilabs/mopup-seed/issues/67 https://github.com/modilabs/mopup-seed/issues/66 https://github.com/modilabs/mopup-seed/issues/65

MartijnR commented 11 years ago

https://github.com/modilabs/mopup-seed/pull/68

remaining issues entered as separate issues