SEL-Columbia / networker

Network Planning Library
4 stars 4 forks source link

Fix requirement versions #codereview #2015may21 #55

Closed vr2262 closed 8 years ago

vr2262 commented 9 years ago

The requirements in requirements.txt have no version specified, so doing $ pip install -r requirements.txt will get the latest version of each depedency. Generally this isn't a problem, but you can't rely on an external dependency to maintain its current public API forever.

You should specify the version of each dependency like

numpy==1.9.2

I recommend using https://gemnasium.com to notify you of when your depedencies are no longer at the latest version so you can check for yourself that newer versions still work.

chrisnatali commented 8 years ago

Closed with #76