search

SEL4PROJ / capdl-loader-app

DEPRECATED: This has been moved to https://github.com/seL4/capdl
http://sel4.systems/CAmkES/
Other
2 stars 2 forks source link

reserved identifier violation #1

Closed elfring closed 9 years ago

elfring commented 10 years ago

I would like to point out that identifiers like "__CAPDL_H__" and "__CAPDL_SPEC_H__" do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

Smattr commented 10 years ago

As per my comments from seL4/camkes#1 and others.

Smattr commented 9 years ago

This issue was resolved in 2b860d1de1ca4dc896c3fa836fd5a91df20794b4. Can someone please close?

elfring commented 9 years ago

Would you also like to reconsider the use of the remaining double underscores in affected identifiers according to the naming convention of the C++ language standard?

lsf37 commented 9 years ago

There is no C++ code in this repository, so I don't think that makes sense.

elfring commented 9 years ago

Would you like to support for your software that the corresponding source files can also be safely handled by C++ compilers?

lsf37 commented 9 years ago

We do not. This software does not run in an environment that supports C++ and should not be used with a C++ compiler.