search

SELab-2 / OSOC-6

MIT License
1 stars 1 forks source link

Feature backend/453 load base data #454

Closed KasperDemeyere closed 2 years ago

KasperDemeyere commented 2 years ago

This pr closes #453.

github-actions[bot] commented 2 years ago

Coverage report for frontend

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements 77.95% 1619/2077
🟡 Branches 67.5% 324/480
🟡 Functions 73.02% 230/315
🟡 Lines 78.61% 1400/1781

Test suite run success

113 tests passing in 38 suites.

Report generated by 🧪jest coverage report action from 863060e9def25da24ce7210ef661515c5429c536

KasperDemeyere commented 2 years ago

@andpuydt Could you please check the email templates in the data.sql file for spelling errors? If you have any improvements to these templates, feel free to suggest them as well.

github-actions[bot] commented 2 years ago
File Coverage [100%] :green_apple:
ResetPasswordToken.java 100% :green_apple:
Communication.java 100% :green_apple:
CommunicationTemplate.java 100% :green_apple:
Invitation.java 100% :green_apple:
UserSkill.java 100% :green_apple:
Edition.java 100% :green_apple:
ProjectSkill.java 100% :green_apple:
SkillType.java 100% :green_apple:
Suggestion.java 100% :green_apple:
Project.java 100% :green_apple:
Assignment.java 100% :green_apple:
UserEntity.java 100% :green_apple:
Student.java 100% :green_apple:
Total Project Coverage 100% :green_apple:
KasperDemeyere commented 2 years ago

Seems good to me! Good work again Kasper! Could you just provide a little doc in this PR why you chose to change the Id generation type.

By setting the id generation type to identity, we let postgres generate the id's instead of spring. This makes it possible for us to insert data using the data.sql file without manually needing to specify id's.

github-actions[bot] commented 2 years ago
File Coverage [100%] :green_apple:
ResetPasswordToken.java 100% :green_apple:
Communication.java 100% :green_apple:
CommunicationTemplate.java 100% :green_apple:
Invitation.java 100% :green_apple:
UserSkill.java 100% :green_apple:
Edition.java 100% :green_apple:
ProjectSkill.java 100% :green_apple:
SkillType.java 100% :green_apple:
Suggestion.java 100% :green_apple:
Project.java 100% :green_apple:
Assignment.java 100% :green_apple:
UserEntity.java 100% :green_apple:
Student.java 100% :green_apple:
Total Project Coverage 100% :green_apple:
github-actions[bot] commented 2 years ago
File Coverage [100%] :green_apple:
ResetPasswordToken.java 100% :green_apple:
Communication.java 100% :green_apple:
CommunicationTemplate.java 100% :green_apple:
Invitation.java 100% :green_apple:
UserSkill.java 100% :green_apple:
Edition.java 100% :green_apple:
ProjectSkill.java 100% :green_apple:
SkillType.java 100% :green_apple:
Suggestion.java 100% :green_apple:
Project.java 100% :green_apple:
Assignment.java 100% :green_apple:
UserEntity.java 100% :green_apple:
Student.java 100% :green_apple:
Total Project Coverage 100% :green_apple: