Misc Clang findings - Githubissues

SELinuxProject / selint

Static code analysis of refpolicy style SELinux policy

Apache License 2.0

38 stars 17 forks source link

Misc Clang findings #249

Closed cgzones closed 2 years ago

dburgener commented 2 years ago

The changes look good, thanks.

I take it we haven't seen these before in the CI because we don't have -Werror enabled on clang builds? Does this PR allow us to enable that on clang? Is that something we want?

cgzones commented 2 years ago

We are already using -Werror in the CI, just not Clang 15:

https://github.com/SELinuxProject/selint/blob/39aa318d77ba404266f008bfdd38c7698c81abb2/.github/workflows/main.yml#L64-L71

dburgener commented 2 years ago

Merged, thanks!