search

SELinuxProject / selinux-notebook

The SELinux Notebook
Other
520 stars 101 forks source link

BUG: fix whitespace bugs in polyinstantiation.md and reference_policy.md #1

Closed tgflynn closed 4 years ago

tgflynn commented 4 years ago

This PR fixes whitespace bugs in two source MD files which cause problems with formatting and links (notably in the TOC) in the generated HTML page.

I'm not sure exactly what the problems were. I just deleted and re-added some apparently blank lines.

pcmoore commented 4 years ago

Hi @tgflynn thanks for the patch. Can you be more specific, maybe even a screenshot, of the HTML rendering problem you are fixing? I'm looking at your patch as well as a HTML rendering that I just made and I'm not seeing anything wrong ... ?

tgflynn commented 4 years ago

Well this is very strange. I can no longer reproduce the issues I was seeing this morning, even just when reloading the exact same html file into chrome. Moreover after looking at this PR with xxd as far as I can see it didn't change anything except perfectly normal \n characters. So I think I must have hit some intermittent bug with chrome rendering that fooled me into thinking that my changes made a difference.

I'm very sorry for wasting your time and I'm closing this PR.

pcmoore commented 4 years ago

No worries, I appreciate you taking the time to submit the patch, even if the root cause wasn't the markdown itself. If you notice anything else off, please let us know and/or submit another PR :)