SELinuxProject / selinux-notebook

The SELinux Notebook
Other
520 stars 101 forks source link

RFE: object_classes_permissions: add io_uring class #20

Closed cukie closed 1 year ago

cukie commented 1 year ago

Fills in documentation for the io_uring object class and the associated permissions. Summary of docs changes:

  1. Change anon_inode to reflect that io_uring is also using type transitions in addition to userfaultfd.
  2. Add an io_uring section documenting the three permissions, override_creds, sqpoll, and cmd.

This change was tested by running make all and verifying formatting in Firefox and Foliate.

Signed-off-by: Gil Cukierman cukie@google.com

cukie commented 1 year ago

Hi @pcmoore any chance these changes could be reviewed and considered? Happy to bring things over to the mailing list if that's preferred.

pcmoore commented 1 year ago

Hi @cukie, yes, this is my review queue - I apologize for the delay - but the is a lot on my plate at the moment and it may take me a bit longer to give this a proper review.

However, you can always feel free to post things to the mailing list too for additional review. Just make sure you make note of it here (preferably with a link to the lore archive post), so that we can dedup the patches later.

Regardless, thanks for helping out with the documentation!

cukie commented 1 year ago

@pcmoore sounds good, thank you! No worries at all on the delay. Just wanted to make sure I was contributing in the expected way.

cukie commented 1 year ago

Thanks for the review, @pcmoore ! Updated with comments addressed.

cukie commented 1 year ago

@pcmoore friendly ping on this!

stephensmalley commented 1 year ago

Reviewed-by: Stephen Smalley <stephen.smalley.work@gmail.com

pcmoore commented 1 year ago

Merged via b0e105688bff73b1af1169ef3a318fdcdc67c8e5, thanks for all your patience on this @cukie!