SELinuxProject / selinux-notebook

The SELinux Notebook
Other
520 stars 101 forks source link

MAINTAINER_PROCESS: add an initial guidance doc for maintainers #28

Closed pcmoore closed 1 year ago

pcmoore commented 1 year ago

@jbrindle, @jwcart2, @dburgener please take a look and let me know if this seems reasonable and if you think we should change anything.

dburgener commented 1 year ago

This seems fine to me. My only comment is that if we are going to have four maintainers right now, then "simple majority", means "3/4", which might be a fairly high bar (particularly since we're in this discussion due to lack of maintainer/reviewer time). I might be inclined to emphasize the "no NACKs and a reasonable amount of time" sort of workflow, and to change "majority" something that means two maintainers is sufficient.

stephensmalley commented 1 year ago

This seems fine to me. My only comment is that if we are going to have four maintainers right now, then "simple majority", means "3/4", which might be a fairly high bar (particularly since we're in this discussion due to lack of maintainer/reviewer time). I might be inclined to emphasize the "no NACKs and a reasonable amount of time" sort of workflow, and to change "majority" something that means two maintainers is sufficient.

Concur - this seems more consistent with how the SELinux userspace maintenance process works; IIRC we only require that at least one maintainer other than the patch author ACK the patch and no maintainers NAK or request changes to it. BTW I am also willing to help with the notebook.

pcmoore commented 1 year ago

That's good feedback, thanks @dburgener and @stephensmalley. I've updated the doc, let me know if this works better for you guys.

pcmoore commented 1 year ago

BTW I am also willing to help with the notebook.

Thanks Stephen. It looks like you should already be setup with the proper permissions, if you notice anything awry let me know.

dburgener commented 1 year ago

Acked-by: Daniel Burgener dburgener@linux.microsoft.com

pcmoore commented 1 year ago

Okay, let's go ahead and merge this so we've got something in place, we can always update later if needed. Thanks all.

Merged via a7ef8dfd72689096574f5967ef383244a69dedb3.