search

SELinuxProject / selinux-testsuite

This is the upstream SELinux testsuite which is designed as a basic set of regression tests for the SELinux kernel functionality.
GNU General Public License v2.0
53 stars 43 forks source link

Fix refpolicy build & build test_policy.pp in Travis #70

Closed WOnder93 closed 5 years ago

WOnder93 commented 5 years ago

This series fixes the remaining test_policy.pp build errors under refpolicy and enables building the test policy under both Fedora policy and refpolicy in Travis CI.

pcmoore commented 5 years ago

Since we decided to start posting test suite patches to the SELinux developers mailing list, it seems redundant to also create PRs here on GitHub doesn't it?

WOnder93 commented 5 years ago

One advantage is that it makes an "official" Travis run on the patches before they are merged. But if that's not worth the redundancy, then just let me know and I'll stop opening the PRs. I have Travis set up to always run on all the branches in my fork so they would still be checked at least with this "private" run.

pcmoore commented 5 years ago

I have Travis set up to always run on all the branches in my fork so they would still be checked at least with this "private" run.

That ^^^ is the important point. I expect that people have fully tested their patches before submission, and GitHub/Travis allows you do that just fine with a private development fork. If people are submitting PRs without adequate testing and relying on the Travis config in the main repo to catch their errors they are Doing It Wrong in my opinion.

WOnder93 commented 5 years ago

Closing this PR in favor of the mailing list postings based on the above.