search

SEMCOG / semcog_urbansim

7 stars 6 forks source link

Proforma calibration #13

Closed janowicz closed 7 years ago

janowicz commented 7 years ago

This PR includes the cost shifting function that gets supplied to the proforma as a callback for calibration purposes. This cost-scaling function reads from /configs/cost_shifters.yaml, which contains geographic levers that auto-calibration adjusts to try and match the observed supply-growth data.

The numeric values in the cost_shifters.yaml included with this initial PR are just for example purposes. Feel free to conduct test runs using this branch to check the mechanics of proforma calibration, but please do not merge until real calibrated values for cost_shifters.yaml come with a later commit. The cost_shifters.yaml configuration file is where the calibration geography is specified (any location identifier column on the parcels table can be used) and where the calibrated cost shifter values live (one for each calibration geography). Proforma costs are multiplied by the shifter value for the relevant geography, so a shifter value of 1.0 means no adjustment to cost. Setting all values to 1.0 would remove the effect of calibration. The current calibration geography is city_id.

Eh2406 commented 7 years ago

This looks good.

Sounds like if we set all the shifters to 1.0 we can test that the code works, then when calibration is done we can merge that separately. Does that make sense, or am I missing something?

janowicz commented 7 years ago

@Eh2406 Yup, that's right! Shifter values of 1.0 keep existing costs as is

Eh2406 commented 7 years ago

Merged looking forward to a calibration PR!