SEMICeu / Core-Location-Vocabulary

A vocabulary that describes the basic elements of location information, such as geometries and addresses.
14 stars 5 forks source link

AdminUnit1 and AdminUnit2 #10

Closed giorgialodi closed 3 years ago

giorgialodi commented 3 years ago

In the definition you say that AdminUnit1 is country/region/state. I am not sure if AdminUnit2 is a country again. Isn't it modelled with the AdminUnit1?

Why AdminUnit1 has a Code as type while AdminUnit2 has text? If it is recommended to use NUTS for AdminUnit2 its type should be a Code, right?

In the table of the definitions for AdminUnit1 the type is missing.

SebastianSK commented 3 years ago

+1

dimi-schepers commented 3 years ago

There was a typo in the label of AdminUnitL2. It should be "county/region/state", and not "country". This was fixed accordingly in the spec, see here.

dimi-schepers commented 3 years ago

The data type for AdminUnitL1 (i.e. Code) was added to the specification, see here.

giorgialodi commented 3 years ago

There was a typo in the label of AdminUnitL2. It should be "county/region/state", and not "country". This was fixed accordingly in the spec, see here.

I think that AdminLevel2 cannot be a text but rather a skos:Concept pointing to a controlled vocabulary (recommended NUTS). See also #12

dimi-schepers commented 3 years ago

During the Core Vocs webinar dd. 2021-05-20, an agreement was reached to use Code as datatype for all the AdminUnitLevels. We propose to continue the discussion on the various levels and which codelist to use per level in issue #12.