SEMICeu / DCAT-AP

This is the issue tracker for the maintenance of DCAT-AP
https://joinup.ec.europa.eu/solution/dcat-application-profile-data-portals-europe
74 stars 24 forks source link

SHACL - The ranges of the properties dcat:hadRole and dct:relation on dcat:Relationship #160

Closed aidig closed 3 years ago

aidig commented 3 years ago

In the DCAT-AP SHACL implementation of the class dcat:Relationship, the range of the property dcat:hadRole is the DcatResource_Shape (dcat:Catalog, dcat:Dataset or dcat:DataService) wheras the range of dct:relation is dcat:Role.

Shouldn't it be the other way around in the context of dcat:Relationsship?

Also, the UML diagram only visualises the the application of dct:relation (on dcat:Relationship) with dcat:Dataset as the range (not dcat:Catalog or dcat:DataService)

aidig commented 3 years ago

snippet from https://raw.githubusercontent.com/SEMICeu/DCAT-AP/master/releases/2.0.1/dcat-ap_2.0.1_shacl_shapes.ttl

:Relationship_Shape
    a sh:NodeShape ;
    sh:name "Relationship"@en ;
    sh:property [
        sh:class dcat:Role ;
        sh:minCount 1 ;
        sh:path dct:relation ;
        sh:severity sh:Violation
    ], [
        sh:minCount 1 ;
        sh:node :DcatResource_Shape ;
        sh:path dcat:hadRole ;
        sh:severity sh:Violation
    ] ;
    sh:targetClass dcat:Relationship .
bertvannuffelen commented 3 years ago

well spotted. The range of dcat:hadRole is dcat:Role. I'll propose an update in the next draft.

bertvannuffelen commented 3 years ago

About the diagram. When the release 2.0.0 was build, the diagram was minorly updated to keep it condensed. But as you points out, in some cases this does not yields the intended representation. In the upcomming geoDCAT-AP release a variant of the diagram is proposed which tries to get this balance better.