search

SEMICeu / DCAT-AP

This is the issue tracker for the maintenance of DCAT-AP
https://joinup.ec.europa.eu/solution/dcat-application-profile-data-portals-europe
74 stars 24 forks source link

SHACL-Webinar: Error Messages / sh:severity #164

Closed init-dcat-ap-de closed 2 years ago

init-dcat-ap-de commented 3 years ago

Thank you again for doing the SHACL-Webinar and releasing the screencast. We now had a chance to revisit the discussed problems and solutions. (See: #162) We want to move forward with the validation of DCAT-AP.de for GovData.de and we would like to do so by re-using the shapes from DCAT-AP.

Around the one hour mark, we discussed the mapping of the usage level in DCAT-AP to the severity-level of SHACL. I think we all agreed, that the mapping 

“mandatory   --> violation”, 
“recommended --> warning” and 
“optional    --> no rule/info”

was correct.

Unfortunately the shacl-specification says that “the value of sh:conforms is true if and only if the validation did not produce any validation results”.

We think that this should not influence the construction of the SHACL-rules. Instead, the EDP should not rely on sh:conforms, but instead check whether or not “true violations” have occurred.

Otherwise we would have to split the rules in different files so that the EDP could use the “violations only” rules for compliance testing.

bertvannuffelen commented 3 years ago

As mentioned in the request, the issue cannot be resolved by adapting or reorganizing the SHACL shapes. It is mainly an interpretation issue at the level of the implementation at the EDP.

On behalve of the DCAT-AP specification, in the draft, the SHACL specification is splitted in several files. The implementation of the recommended property constraints will yield an additional SHACL file.

bertvannuffelen commented 3 years ago

A shacl file containing the recommended properties is added in the proposal: https://github.com/SEMICeu/DCAT-AP/blob/2.1.0-draft/releases/2.1.0/dcat-ap_2.1.0_shacl_shapes_recommended.ttl