search

SEMICeu / DCAT-AP

This is the issue tracker for the maintenance of DCAT-AP
https://joinup.ec.europa.eu/solution/dcat-application-profile-data-portals-europe
72 stars 24 forks source link

Shacl rule for owl:versionInfo too restrictive, allows only one versionInfo #225

Closed init-dcat-ap-de closed 2 years ago

init-dcat-ap-de commented 2 years ago

The following rule restrictes the number of owl:versionInfo to 1:

:Dataset_Property_owl_versionInfo
    sh:maxCount 1 ;
    sh:nodeKind sh:Literal ;
    sh:path owl:versionInfo ;
    sh:severity sh:Violation .

In theory, this would be a problem, if someone wants to provide owl:versionInfo in multiple languages. I think we should use sh:uniqueLang for this:

:Dataset_Property_owl_versionInfo
    sh:uniqueLang true ;
    sh:nodeKind sh:Literal ;
    sh:path owl:versionInfo ;
    sh:severity sh:Violation .
bertvannuffelen commented 2 years ago

This is actually a specification change,

It seems like one with a low impact. But lets investigate the case:

The current usage note is "This property contains a version number or other version designation of the Dataset.".

My question based on this usage note is that the usage note seems to suggest a technical representation of the version, which somehow is language neutral. While you seem to refer to maybe some more descriptive text as value. I think that is the underlying reason for the max-cardinatity of 1 and not unique in the language.

init-dcat-ap-de commented 2 years ago

Thank you for the clarification. It seems like I thought about adms:versionNotes when writing the issue. But adms:versionNotes already has the cardinality of *.

In my opinion this issue can be closed.