Closed bertvannuffelen closed 3 years ago
ok, I will include them.
kr,
Bert
Op di 29 sep. 2020 om 16:52 schreef Andrea Perego <notifications@github.com
:
@andrea-perego requested changes on this pull request.
Thanks, @bertvannuffelen https://github.com/bertvannuffelen .
I added some inline comments proposing editorial changes.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SEMICeu/GeoDCAT-AP/pull/17#pullrequestreview-498558183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPIC3JNMROIIHEGVYD3SPDSIHYBNANCNFSM4R5SZE3Q .
BTW, to accept the changes, you just have to go to
https://github.com/SEMICeu/GeoDCAT-AP/pull/17
The proposed revisions are all listed there, and there is a button to commit the changes.
About the diagram, I noticed that not all the GeoDCAT-AP specific properties are included (see, e.g., class Agent). Is this intentional?
Thanks
Andrea
On Tue, Sep 29, 2020 at 5:03 PM bertvannuffelen notifications@github.com wrote:
ok, I will include them.
kr,
Bert
Op di 29 sep. 2020 om 16:52 schreef Andrea Perego < notifications@github.com
:
@andrea-perego requested changes on this pull request.
Thanks, @bertvannuffelen https://github.com/bertvannuffelen .
I added some inline comments proposing editorial changes.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/SEMICeu/GeoDCAT-AP/pull/17#pullrequestreview-498558183 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAPIC3JNMROIIHEGVYD3SPDSIHYBNANCNFSM4R5SZE3Q
.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/SEMICeu/GeoDCAT-AP/pull/17#issuecomment-700767645, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLIAX7Z4FUHIAUIIBMAMTLSIHZMZANCNFSM4R5SZE3Q .
A selected number of updates resolving a number of editor notes.
Preview:
https://raw.githack.com/bertvannuffelen/GeoDCAT-AP/develop/drafts/latest/index.html