search

SEMICeu / GeoDCAT-AP

Repository of the geospatial extension to DCAT-AP (GeoDCAT-AP)
https://joinup.ec.europa.eu/solution/geodcat-application-profile-data-portals-europe
Creative Commons Attribution 4.0 International
19 stars 6 forks source link

Update Section "Terminology" #45

Closed bertvannuffelen closed 3 years ago

bertvannuffelen commented 3 years ago

remove the redundant definitions on dataset, data service from the terminology section remove editorial notes and outcommented sections

The section now only contains generic terminology. For coherency formal definitions of business terminology are best placed in the definition section of that term. Intuitive guidance on the business terminology is covered in the introductions.

andrea-perego commented 3 years ago

Thanks for this revision, @bertvannuffelen .

A couple of comments:

  1. I see that you removed the definition of Dataset, Data Service and Data Portal, although these notions are not domain specific. Could you please explain?

  2. The PR is not addressing the issue concerning the inconsistent definition of recommended classes and recommended properties - which should be aligned, I guess.

bertvannuffelen commented 3 years ago

A couple of comments:

  1. I see that you removed the definition of Dataset, Data Service and Data Portal, although these notions are not domain specific. Could you please explain?

These definitions are according to me already present at the normative sections such as https://semiceu.github.io/GeoDCAT-AP/releases/2.0.0/#mandatory-classes

If the removed definitions not coïncide, or are different then we should incorporate them at these places. I would avoid to have 2 normative sections for them.

  1. The PR is not addressing the issue concerning the inconsistent definition of recommended classes and recommended properties - which should be aligned, I guess.

no, that I did not addressed here.

andrea-perego commented 3 years ago

A couple of comments:

  1. I see that you removed the definition of Dataset, Data Service and Data Portal, although these notions are not domain specific. Could you please explain?

These definitions are according to me already present at the normative sections such as https://semiceu.github.io/GeoDCAT-AP/releases/2.0.0/#mandatory-classes

If the removed definitions not coïncide, or are different then we should incorporate them at these places. I would avoid to have 2 normative sections for them.

Understood. +1 from me.

  1. The PR is not addressing the issue concerning the inconsistent definition of recommended classes and recommended properties - which should be aligned, I guess.

no, that I did not addressed here.

I'll then draft a proposal in a separate PR.