SEMICeu / dcat-ap_shacl

DCAT-AP SHACL constraint definitions
https://github.com/SEMICeu/dcat-ap_shacl
12 stars 3 forks source link

Mandatory class test #6

Closed costezki closed 7 years ago

costezki commented 7 years ago

Shall we check for presence of mandatory class instances in the data-set and if so which ones?

Currently there are three shapes :MandatoryAgent, :MandatoryCatalog and :MandatoryDataset that are checking for presence of at least one instances of foaf:Agent, dcat:Catalog and dcat:Dataset.

Shall we keep or remove them?

PS: this leads me to a broader question: when we validate a data-set want do we want to verify?

makxdekkers commented 7 years ago

From my perspective, I do not really know what is gained by checking mandatory classes so I would vote for removing the shapes. I am not sure what the difference between the two choices is. Isn't 'conforming' the same as 'not violating'?

costezki commented 7 years ago

What I meant is the following: in case of an incomplete DCAT description (e.g. only a "correct" catalog instance is available):

I would also vote in favor of "reactive" approach, to only check whether the provided data does not violate the AP without imposing some minimal constraints on their completeness (i.e. request that there is at least one Dataset instance in addition to the provided Catalog instance)

Already submitted a modification where I split the MandatoryClass checks into another module.