SEMOSS / semoss-ui

Apache License 2.0
17 stars 3 forks source link

[TASK] Admin Edit/Add User bug Fixes #284

Closed ppatel9703 closed 1 week ago

ppatel9703 commented 1 month ago

Description

When adding and editing new users from admin member setting the following issues need to be fixed

Existing

Is there any relevant code or ui feature that the developer should know about when resolving this issue.

Reference

This issue references. . .

Screenshot 2024-09-16 at 2 10 24 PM

Tasks

What are more specific tasks that a developer needs to take to consider this issue resolved.

ppatel9703 commented 1 month ago

@johbaxter Matt Freshwaters is going to work on this he wants to know if the phone is required when adding/editing a user

johbaxter commented 1 month ago

@mattfreshwaters and @ppatel9703 - I do not think it is required off my head. Please take a look at our logic for register, it should match to that exact logic. We can also look at the validation we have on the BE for this. Take a look at the API route, do we require it on Edit and Add, if so lets just match that logic on BE

mattfreshwaters commented 3 weeks ago

@ppatel9703 @johbaxter This is wrapping up - quick question because I noticed what I thought were 2 smaller bugs during this, not sure if I should go ahead and create new tickets for them? Or if we want to add on here. Primarily:

ppatel9703 commented 3 weeks ago

@mattfreshwaters @johbaxter Matt if you have time, go ahead and address those two issues as well. I'll update to the ticket to include those two bugs (not sure if you have access to) If you don't have time we can make a new ticket and sign it off during sprint review.

mattfreshwaters commented 3 weeks ago

@ppatel9703 Sounds good! Need to nail down to things for MDE today but I'll get cracking on it asap

johbaxter commented 3 weeks ago

@mattfreshwaters please put estimated completion data. Just for planning on my side with code review

mattfreshwaters commented 3 weeks ago

@johbaxter Lets say this Friday Sept 27th - client work permitting, will update if that seems unrealistic later on in the week