search

SEMOSS / semoss-ui

Apache License 2.0
17 stars 3 forks source link

284 task admin editadd user bug fixes #303

Closed mattfreshwaters closed 1 week ago

mattfreshwaters commented 3 weeks ago

For issue https://github.com/SEMOSS/semoss-ui/issues/284

Regex is fixed so form doesn't think XXX-XXX- is a valid phone number, accepst (XXX) XXX-XXXX or XXX-XXX-XXXX

Now sending 'newEmail' instead of 'email' to the backend for editUser

Error messages on the editUser form are now in red

johbaxter commented 2 weeks ago

image

Is there a reason we don't pull in email into the modal. @mattfreshwaters

johbaxter commented 2 weeks ago

image image

@mattfreshwaters also the way we send it versus the way we receive it are totally different can we have some consistency

mattfreshwaters commented 2 weeks ago

image image

@mattfreshwaters also the way we send it versus the way we receive it are totally different can we have some consistency @johbaxter Assuming you're referencing the phone number - yep can do that. Do we have a preference of what format? Figured for user sake it is easiest if they have different options to type in, but we can adjust and send a single format to the backend (i.e. 123-456-7890) for consistency - thoughts?.

mattfreshwaters commented 2 weeks ago

@johbaxter backend PR here: https://github.com/SEMOSS/Semoss/pull/171 created an issue for it in Semoss as well - https://github.com/SEMOSS/Semoss/issues/140