search

SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
22 stars 21 forks source link

Correct typo in adios2_init version selection #116

Closed vicentebolea closed 1 year ago

vicentebolea commented 1 year ago

Followup of #114

In #114 we accidentally wrote:

#if ADIOS2_VERSION_MAJOR > 2 || (ADIOS2_VERSION_MINOR == 2 && ADIOS2_VERSION_MINOR >= 9)

However, what we want is:

#if ADIOS2_VERSION_MAJOR > 2 || (ADIOS2_VERSION_MAJOR == 2 && ADIOS2_VERSION_MINOR >= 9)
vicentebolea commented 1 year ago

@burlen

burlen commented 1 year ago

ok, no problem. Apparently spack ci setup has not been updated to test w/ 2.9 otherwise I assume this would have been caught before the last merge. Would it make sense to include those changes for the spack ci in this pr so that we have testing of this change before it goes in?