search

SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
22 stars 21 forks source link

Add particles metadata #128

Closed danlipsa closed 1 year ago

danlipsa commented 1 year ago

@burlen @patrickoleary @c-wetterer-nelson Please review

danlipsa commented 1 year ago

@burlen Something wrong with the fedora35 ci?

danlipsa commented 1 year ago

Can I run all the tests on my local machine?

burlen commented 1 year ago

@danlipsa not sure what's up with the spack builds, but we have seen that before. I'm confident it is not related to your work here. if anything rebase from latest develop (if it is out of date) before merging.

danlipsa commented 1 year ago

Thanks @burlen . Can you merge as well. I don't have merge permission. Thanks!

willdunklin commented 1 year ago

@burlen @danlipsa Hey guys, I'm running into more test failures from this PR for the ecp integration testing.

It seems like the extra mesh example introduced in this commit is the culprit for all of the test failures.

I'm not at all familiar with the project, so would you mind taking a look at how it might be fixed? I believe the particle list is empty from my testing, which makes the block metadata differ from the expected values initialized above.

danlipsa commented 1 year ago

Can you post a link of the failures?

willdunklin commented 1 year ago

This should be the same error I was getting https://github.com/SENSEI-insitu/SENSEI/actions/runs/5113440514/jobs/9192645602#step:7:1312

burlen commented 1 year ago

The metadata has some issues after the change. Those tests only run if you compile sensei with vtk support (or Paraview).

danlipsa commented 1 year ago

Does this fix it? https://github.com/SENSEI-insitu/SENSEI/pull/131

willdunklin commented 1 year ago

Yep that looks good to me