SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
22 stars 22 forks source link

SENSEI-5.0.0.tar.gz does not contain HAMR source #145

Closed danlipsa closed 11 months ago

danlipsa commented 11 months ago

After downloading SENSEI-5.0.0.tar.gz

[~/Downloads]$ tar xzf SENSEI-5.0.0.tar.gz 
[~/Downloads]$ ls -l SENSEI-5.0.0/utils/HAMR
total 0
kwryankrattiger commented 11 months ago

I am guessing we need to do what we do for ParaView and generate the tarball from a copy of the source with the submodule cloned.

The way the release process is supposed to work is to build a tarball manually that contains all of the required source in it and upload it separately.

danlipsa commented 11 months ago

Indeed. So how do we fix this? It is fairly easy to re-upload the right tar.gz.

danlipsa commented 11 months ago

@burlen Any suggestions? Thanks!

danlipsa commented 11 months ago

Thanks @kwryankrattiger for uploading the corrected tgz

danlipsa commented 11 months ago

@kwryankrattiger We would want to update v5.0.0.tar.gz and v5.0.0.zip files as well. (or delete them) because they are the version without the HAMR source (at least the tar.gz is).

kwryankrattiger commented 11 months ago

We would want to update v5.0.0.tar.gz and v5.0.0.zip files as well. (or delete them) because they are the version without the HAMR source (at least the tar.gz is).

Those are automatically populated by github based on the tag. I don't know how to disable those.

danlipsa commented 11 months ago

Somehow, those were updated 2 weeks ago (so they are the wrong versions) while SENSEI-5.0.0.tar.gz was updated yesterday.

kwryankrattiger commented 11 months ago

Two weeks ago that tag was pushed, which generated those tarballs automatically. I uploaded the SENSE-5.0.0.tar.gz yesterday generated from the source associated with that tag.

danlipsa commented 11 months ago

Oh, I see. So tagging triggered something on github that build those packages. Unfortunately it built them wrong because it does not account for git submodules

kwryankrattiger commented 11 months ago

Right, here is a discussion about disabling the feature but no updates redcently: https://github.com/orgs/community/discussions/6003