search

SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
21 stars 22 forks source link

Catalyst Adaptor without Python #56

Open kwryankrattiger opened 2 years ago

kwryankrattiger commented 2 years ago

It looks like everything is guarded except for this one spot.

../sensei/CatalystAnalysisAdaptor.cxx:411:27: error: no member named 'CatalystScriptPipeline' in namespace 'sensei'
      auto data = sensei::CatalystScriptPipeline::GetResultData(proc);
                  ~~~~~~~~^

It looks like maybe this is not quite correct, it assumes catalyst is always python based.

kwryankrattiger commented 2 years ago

I am not sure if the correct solution here is to just disable using Catalyst without python (ie. Removing the ENABLE_CATALYST_PYTHON and just require that catalyst always provides python) or to fix this so that it passes things correctly with/without python.

burlen commented 2 years ago

we also have some C++ only catalyst cases. so I think that this is simply missing the if defs to remove it when catalyst python is not present.