SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
21 stars 22 forks source link

Warning when analysis/transport is not enabled #99

Closed jwindgassen closed 1 year ago

jwindgassen commented 1 year ago

For clearer Feedback to the user, they should be informed when an analysis/transport in the XML is not enabled. As currently, it will be silently dropped and ignored.

I decided to use SENSEI_WARNING, but using SENSEI_STATUS would also be possible here if that is too verbose.

I would also argue, that it would be more intuitive, if the default value of the enabled attribute is true, but decided to leave it be for now.

jwindgassen commented 1 year ago

I think the best way would be either:

burlen commented 1 year ago

we took the opposite approach to report when an analysis was enabled. meaning if you don't see a report that you expected you know it was skipped. However, I'll merge this if you change warning to a status report.

burlen commented 1 year ago

also, having things default to enabled makes sense to me.

burlen commented 1 year ago

@jwindgassen thank you!