Configuration via YAML - Githubissues

mauricioaniche commented 1 year ago

Configurations are provided to Andy via a Java file that we, as teachers, have to write. The idea of making it into a Java class is that we'd get the support of the compiler to know if something is wrong. In practice, we never write these files in an IDE. It's always in WebLab. And because of that, the verbosity of Java is cumbersome.

We should support configuration via YAML files.

Suggestion:

If there's a YAML file provided, we use it instead of the RunConfiguration.
We parse the YAML file (feel free to bring a library for that) and put it in a class that extends RunConfiguration
If something is missing, throw early exception and stop the execution, so that the teacher gets notified quicky.
Everything else should work after that, as Andy just expects an instance of RunConfiguration.

Idkwhoami42 commented 1 year ago

Hi! I'd like to try implementing this feature. Can I be assigned to this issue?

mauricioaniche commented 1 year ago

Hey, @Idkwhoami42, go for it!

Idkwhoami42 commented 1 year ago

Hi, I had a question regarding type safety of the YAML file. Should I implement proper type safety and checks (with specific errors messages).

mauricioaniche commented 1 year ago

Great question, @Idkwhoami42! I don't think we need a full-blown super detailed type checker, but if anything is wrong, we should stop Andy and let the teacher know. Any extra hint to identify the problem in the exception message is welcome!

mauricioaniche commented 1 year ago

Hi, @Idkwhoami42, are you still working on this one?

Idkwhoami42 commented 1 year ago

Hi, Sorry for the bad communication, I was quite busy with exams and travelling.. but now I can start working on it again. I had implemented most of it before so shouldn't take that long hopefully. Sorry for the delay!

mauricioaniche commented 1 year ago

Awesome!!

SERG-Delft / andy

Configuration via YAML #164