Closed just-rares closed 1 year ago
Approved workflow run.
I just noticed the GradeWeights
class. It also does some validations there (doesn't allow the sum not to be 100%). Are you using it here?
I'm closing this one for now. We can always re-open once you are back to it!
This pull request solves issue #173
Added a method in the
GetRunConfigurationStep
that checks the weights of the RunConfiguration and asserts whether they are valid with all the information available at the moment.Changes:
If the configuration is invalid, the default one is set and an exception is thrown.
I tests the functionality of this method in the
RunConfigurationTests
file, where I used both unit tests to check the requirements of the method under test, some mocking to allow for disabling Pitest and Jacoco and one integration test with a library file with invalid weights to assert the error is indeed thrown and caught in theResult
file.Notes:
GradeCalculator
. Some of the checks could not be done, such as the one with the grades. If it should be removed, please do let me know.Any suggestions are welcomed, I am not very confident about my implementation of this issue