search

SERG-Delft / andy

Andy assesses student's test code. It's used in CSE1110, TU Delft.
MIT License
78 stars 22 forks source link

Refactor getNumberOfPassedChecks method #219

Open martinmladenov opened 1 year ago

martinmladenov commented 1 year ago

The getNumberOfPassedChecks in CodeChecksResult method currently accepts a boolean.

One way to avoid this boolean would be to offer two methods weightedNumberOfPassedChecks.

See this blog post explaining this Clean Code rule: https://www.informit.com/articles/article.aspx?p=1392524

_Originally posted by @mauricioaniche in https://github.com/cse1110/andy/pull/210#discussion_r1225873677_

vesk4000 commented 1 year ago

I'd love to do this issue

martinmladenov commented 1 year ago

Thanks, I assigned you. Let me know if you have any questions :)