search

SERG-Delft / andy

Andy assesses student's test code. It's used in CSE1110, TU Delft.
MIT License
78 stars 22 forks source link

Make Docker tests work in forks/pull requests #220

Closed martinmladenov closed 1 year ago

martinmladenov commented 1 year ago

Currently Docker assignment tests only run on pushes, not on pull requests.

Furthermore, the Dockerfile has the repo URL hardcoded. This causes it to break when it runs in a fork, as commits in forks are not present in the upstream repo. The URL should default to this one but it should be set in the CI via environment variables. GitHub provides such environment variables which we can use.

Arraying commented 1 year ago

I no longer have permissions to assign issues, can I take this one? :)

martinmladenov commented 1 year ago

Of course :)