SERG-Delft / andy

Andy assesses student's test code. It's used in CSE1110, TU Delft.
MIT License
78 stars 23 forks source link

Remove unnecessary check #254

Closed martinmladenov closed 1 year ago

martinmladenov commented 1 year ago

Lines 75-77 of LibraryMetaTest.java have the following code:

        if (metaFileContent.equals(originalLibraryContent)) {
            throw new RuntimeException("Meta test " + getName() + " failed to replace code.");
        }

This code doesn't do anything, as the meta file content is always a shifted version of the original, where all indentation is removed, so the exception will never be thrown. We already do a (proper) check for this in the StringReplacementEvaluator, so this check should be removed.

adeelFeroz77 commented 1 year ago

Please assign me this issues. I want to contribute.