Removed comments + added line highlight at position of keyword

SERG-Delft / andy

Andy assesses student's test code. It's used in CSE1110, TU Delft.

MIT License

78 stars 23 forks source link

Removed comments + added line highlight at position of keyword #268

Open alexcojocaru2002 opened 12 months ago

alexcojocaru2002 commented 12 months ago

Closes #213

The aim of this Pull Request is to improve the SourceCodeSecurityCheckStep class.

[x] Change name of the class
[x] Remove comments when checking code
[x] When having an error highlight the corresponding line and not line 1.

alexcojocaru2002 commented 12 months ago

@martinmladenov How should I rename the class ? Also should I write a separate test for removeComments method ?

martinmladenov commented 11 months ago

@alexcojocaru2002

@martinmladenov How should I rename the class ? Also should I write a separate test for removeComments method ?

Good question, I haven't thought about that. Maybe something like "SourceCodeCheckStep" would be suitable (but this could be misleading as people might think it has to do with code checks). If you think of anything more suitable, feel free to use that instead. @mauricioaniche Do you have any ideas?

mauricioaniche commented 11 months ago

SourceCodeCheckStep looks good to me!