search

SERG-Delft / jpacman-framework

Pacman-inspired game, for teaching testing purposes.
126 stars 253 forks source link

Improve nullness annotations #104

Closed mernst closed 7 years ago

mernst commented 7 years ago

This pull request removes some warning suppressions, puts others in a smaller scope, and improves formatting by putting type annotations right before types instead of before method modifiers.

avandeursen commented 7 years ago

Thank you very much!!

Very nice indeed. Also thanks for using separate commits making it possible to revert individual changes.

The annotation/modifier order calls for a separate checkstyle / PMD rule, but I could not find an existing one.

mernst commented 7 years ago

To enforce correct annotation/modifier order, a tool needs to know which annotations are declaration annotations and which annotations are type annotations. I use the scripts at https://github.com/plume-lib/run-google-java-format to format the entire source code, which includes the type annotations.