search

SERG-Delft / jpacman-framework

Pacman-inspired game, for teaching testing purposes.
123 stars 254 forks source link

Cucumber Interference #83

Closed avandeursen closed 7 years ago

avandeursen commented 8 years ago

The Framework's Cucumber features and step definitions are part of the test jar, which is imported in the template. This has the effect that the same step definitions also apply in solutions based on the template, which is counter intuitive.

A solution might be to drop the test jar dependency in the template.

The 'workaround' now is

  1. To use a uniquely named feature folder in the solution
  2. To shadow nl.tudelft.jpacman.cucubmer.StateNavigationSteps by having that same package/class in the solution.
jwgmeligmeyling commented 8 years ago

Why include the test-jar in the first place? See also this comment: https://github.com/cucumber/cucumber-jvm/issues/999#issuecomment-216536644

avandeursen commented 8 years ago

Right. The test-jar was there to make some of the (static) methods of the LauncherSmokeTest available, as well as the BasicSquare class (effectively a mock square).