search

SERG-Delft / jpacman-framework

Pacman-inspired game, for teaching testing purposes.
123 stars 254 forks source link

Move to JUnit 5 #99

Closed avandeursen closed 7 years ago

avandeursen commented 7 years ago

Experimental branch with JUnit 5 version of JPacman.

This move also implies a systematic adoption of AssertJ (and dropping of hamcrest).

All seems to working fine -- still exploring the impact on some of the exercises.

Feedback welcome.

(Do not merge yet).

TimvdLippe commented 7 years ago

So we are going to disable this bot? :joy:

avandeursen commented 7 years ago

Did anyone enable the Codacy bot?

The rules of the bot should be checkable local as well, through maven.

Are unsolicited bot remarks in agreement with the GitHub terms of service?

TimvdLippe commented 7 years ago

Maybe @JWGmeligMeyling or @michaeldejong enabled it?

jwgmeligmeyling commented 7 years ago

No I didn't, pretty sure Michael didn't too.

Jan-Willem

avandeursen commented 7 years ago

I propose to merge this in, and commit to using JUnit 5.

avandeursen commented 7 years ago

OK, I ~will block~ have blocked this tool as per https://github.com/codacy-bot/how-to-unsubscribe