SEServerExtender / EssentialsPlugin

Dedicated Essentials Plugin
GNU Lesser General Public License v3.0
18 stars 18 forks source link

GreetingItem and GreetingNewUserItem are not functioning or configurable #17

Closed zrisher closed 8 years ago

zrisher commented 9 years ago

Hi there,

Looking at the greeting dialog settings and in-game chat commands for editing settings it seems like I should be able to edit the GreetingItem and GreetingNewUserItem settings using the standard chat commands. These commands work great for me for GreetingEnabled, GreetingMessage, and I tested the array operations with BackupItems to make sure that wasn't the problem.

But when I try: /admin settings GreetingItem

I get: Server: Getting Value(s) for Setting: GreetingItem and then a blank line. No description of the current values, but no warnings I'm using it incorrectly either.

I've tried accessing the values as GreetingItem.Enabled, GreetingItem.0, GreetingItem.1, GreetingItem.0.Enabled, etc, nothing. None of the array operations return an error or a success message.

What are the proper chat commands to set this setting's values?

zrisher commented 9 years ago

These also don't seem to be picked up from editing the Essentials-Settings.xml files.

dodexahedron commented 9 years ago

I've never seen a greeting dialog work, even from before I picked up the project. I'll look into that, eventually, but it'll be a lower priority than other things unless I get a lot of requests for it. Regular greeting chat items do work, though. Depending on the size of your world and how quickly a user actually gets into the game, they may miss those greetings, though. Not a lot I can do about that in the current state of things.

zrisher commented 9 years ago

That makes sense. Yes, the reason I was looking to use these was to ensure the user actually saw it, as well as the ability to display a lot of text at once and still have it be easily accessible. Understood this is low pri. I'll adjust the title of the ticket to reflect the underlying problem.

togosh commented 9 years ago

Hey Dox,

The greeting dialog feature is amazing, and high priority on my list, it allows you to send a longer amount of textual information to a new user, for instance: Rules, Settings, Tips, etc. A lot of users just randomly join servers and do not read the servers website or steam group and then fill up the chat with a bunch of basic questions about the sever. The greeting dialog fits that communication need.

I wish I had more details (two admins with no tool upgrade documentation atm) but it has been somewhere a week or two ago, our greeting dialog stopped working.

dodexahedron commented 9 years ago

I'll be sure it makes it on my list. I think turret management and a couple of other broken things are probably higher priority, at the moment, but this will be in my top 5.

DigTron commented 9 years ago

Strange, works fine for me on 5 servers using dodex's extender/esssentials and has done for weeks...and before using dodex's too.... there was a breif spell when the chat handler was skrewy (and so greeting was not working) but I think that was fixed by Tyrsis and Dodex individually... was around the time vrage.common.dll was dropped.

I think your problem is with the chat commands. Are the settings changes showing in the xml file ?

Try altering the settings xml in a text editor if you dont have access to the gui, and upload to your server or ask your host to place the file. You will need to reset the server or reload the plugin (bad idea?) for the changes to be read by essentials...

Also if you edit the xml directly and then attempt to change a setting via gui or chat command your changes will be overwritten.

Here is a copy of my settings from one of the servers.

          <RestartWhenUnresponsive>true</RestartWhenUnresponsive>
          <GreetingEnabled>true</GreetingEnabled>
          <GreetingMessage>yadda yadda yadda</GreetingMessage>
          <GreetingPublic>false</GreetingPublic>
          <GreetingItem>
            <Enabled>true</Enabled>
            <Title>READ FIRST - FIND CONTENTS BELOW</Title>
            <Header>yadda yadda yadda</Header>
            <Contents>yadda yadda yadda 

         </Contents>
            <ButtonText>HAPPY HUNTING</ButtonText>
          </GreetingItem>
          <GreetingNewUserMessage>!!-Type /motd for info at any time</GreetingNewUserMessage>
          <GreetingNewUserItem>
            <Enabled>true</Enabled>
            <Title>READ FIRST - FIND CONTENTS BELOW</Title>
            <Header>yadda yadda yadda</Header>
            <Contents>yadda yadda yaddda

            </Contents>
            <ButtonText>HAPPY HUNTING</ButtonText>
          </GreetingNewUserItem>
          <BackupEnabled>true</BackupEnabled>
zrisher commented 9 years ago

@DigTron, thanks but I actually had already tried placing this info in my Essentials-Settings.xml file once I'd generated it by using some of the other settings commands. No dice. I also tried copying your GreetingItem and GreetingNewUserItem into my file, but it didn't work either (It actually seems to have caused a re-write of my config file, all my other values are gone. But I backed up.)

DjKiDD commented 9 years ago

I managed to get the dialog box working. Dialog is shown when motd message is given. I have it setup to send motd to new users to agree to a dialog box. If set it public it will show the words motd when a new player joins. You can also see the dialog by typing /motd into the chat with /info enabled (atleast I have it enabled, haven't tested without it...)

zrisher commented 9 years ago

@DjKiDD so which setting did you change? Or what command did you use to do it?

Using the chat commands, mine are below:

GreetingEnabled = true
GreetingMessage = "Welcome to Gardens of Sajuuk! Type /info for info."
GreetingNewUserMessage = ""
GreetingPublic = false
GreetingItem = ? This responds to get with "" but doesn't change when set
GreetingItem.Enabled = ? Same as above
GreetingNewUserItem = ? Same as above
GreetingNewUserItem.Enabled = ? Same as above

InformationEnabled = true
InformationItems.0 = { Enabled: True, Subcommand: 'motd',
  Message: 'Welcome...', IntervalSeconds: 1800 }

I still think the problem has something to do with the fact that I can't set or access the GreetingItem property settings.

DjKiDD commented 9 years ago

I will post my config when I get home. I have never gotten a chat command to work for me. It acts all helpful giving possible sub command but no information. I have resorted to changing the settings manually through the server extender plugin section.

DjKiDD commented 9 years ago

244850_screenshots_2015-05-09_00001

http://pastebin.com/vJrJ8tB4 <-- FULL XML

Some observations. In order to display the message you need to set the greeting to motd Notice NewUserGreetingMessage is set to motd the result is the screen shot above when a new user connects to warn them about clean ups.

Just typing /motd into chat use to pop up the dialog as configured. It seems to only show "No MOTD dialog defined on the server" so not sure where to set that up now... but I swear it works for me.

zrisher commented 9 years ago

I'm unable to access the Extender GUI client as I'm on a server managed by SESM (hostaspace.com). So I need to be able to do this through chat commands or config file editing.

When you say "you need to set the greeting to motd", what do you mean exactly? Are you saying we should set GreetingMessage = "motd"? That's not the case in your pasted settings. I also don't see NewUserGreetingMessage anywhere in your settings, but I do see GreetingNewUserItem is set to the dialog box show in your screenshot. But again, I've tried pasting these into my xml settings with no effect. I can't edit them in-game.

DjKiDD commented 9 years ago

<GreetingNewUserMessage>motd</GreetingNewUserMessage> is what it is saved as in the XML I guess, I honestly did not look at it too hard. I just happen to only want new users to see this message the very first time. It will display everytime I log in if I set <GreetingMessage> to motd As far as chat commands go I do not believe the admin commands work at all, at least not for me in game.

-<GreetingNewUserItem> <Enabled>true</Enabled> <Title>Alert!</Title> <Header>Terms and Conditions</Header> <Contents>Due to general lag related issues any ship that uses the default name will be deleted nightly at 4:20 AM</Contents> <ButtonText>I won't bitch when my ship is deleted.</ButtonText> </GreetingNewUserItem>

Looks like you might be leaving out the -<GreetingNewUserItem> or -<GreetingItem> tags? Also do not put it in "quotes" the greeting message.

DigTron commented 9 years ago

Hey sorry I never came back, not sure if you got this sorted but a sure fire way of getting this to work is to edit your settings file like I described, restart your server, and it should post. Using /motd will show it again. Its also important to note that there are two sets of settings, one for users that are new and one for users who are not.

GreetingItem and GreetingNewUserItem contain

<Enabled>true</Enabled>    <!-- sets whether or not the message is enabled  -->
<Title>READ FIRST - FIND CONTENTS BELOW</Title>   <!-- Large text at the top of the window -->
<Header>yadda yadda yadda</Header>     <!-- Smaller text at the top of the window (below the Title) -->
<Contents>yadda yadda yadda </Contents> <!-- The main body of text -->
<ButtonText>HAPPY HUNTING</ButtonText>  <!-- ButtonText -->

Don't have experience with the chat commands your using to change the settings so I cant help there with any confidence. But ill mess with them at some point and see if/why they are/aren't working.

This #26 would allow you to reload the config from a chat command without having to reload the plug-in or restart the server.

DigTron commented 9 years ago

The original name "Unable to interact with GreetingItem and GreetingNewUserItem settings via chat " describes the issue better.

zrisher commented 9 years ago

I could never get this to work, despite editing settings exactly as described and restarting numerous times. That said, I've moved away from using Extender so if I'm the only person still having this issue this can be closed.

joemorin73 commented 9 years ago

I use this myself. Although it's been sporadic in the last update or two.

SilentSymphony commented 9 years ago

I've been using this since the beginning, It has never been 100% reliable for me.

My main servers map is getting pretty old now, With it some performance is sacrificed and the farther we go the less and less i see it popping up.

Any future improvements to this would be greatly appreciated.

dodexahedron commented 9 years ago

I really do think this has to do with people just missing it, due to how long it takes to load into the game. The events that fire off the chat message happen before people are typically actually able to see in-game chat. I'm not sure if there is anything I can do about it, server-side. This may require interaction with a client-side plugin to make totally reliable.