search

SEServerExtender / EssentialsPlugin

Dedicated Essentials Plugin
GNU Lesser General Public License v3.0
18 stars 18 forks source link

Block Enforcement - Grids connected by connectors treated as one grid #29

Open togosh opened 9 years ago

togosh commented 9 years ago

Currently, I limit certain blocks per grid on my server with Block Enforcement, for instance: turrets,

When a player connects their Fighter ship with turrets, to say his/her main Station that has its own turrets, the Block Enforcement will treat the Fighter ship and Station as one grid, and turrets will be removed.

Would it be possible for Block Enforcement to treat grids connected with connectors as separate grids?

dodexahedron commented 9 years ago

Unfortunately, no. The game merges them into a single entity, which is why Essentials sees them as one. I'm not aware of a way, at present, to treat them as individual ships, with the tools currently available. But I, too, would like for that to be the way it behaves, so I'll keep my eyes open for that as I'm digging through the code.

Ragnar24 commented 9 years ago

This is just a quick thought, but might create other issues. What if the block enforcement ignored grids who has their connectors that are on lock position, like if(!connectorlocked){ block enforcement}?

dodexahedron commented 9 years ago

Problem is that makes it an exploit. All someone ever has to do to get around the limit is build an extra reactor and a connector.

-----Original Message----- From: "Ragnar24" notifications@github.com Sent: ‎5/‎1/‎2015 8:29 PM To: "SEServerExtender/EssentialsPlugin" EssentialsPlugin@noreply.github.com Cc: "dodexahedron" brandon@dodecatec.com Subject: Re: [EssentialsPlugin] Block Enforcement - Grids connected byconnectors treated as one grid (#29)

This is just a quick thought, but might create other issues. What if the block enforcement ignored grids who has their connectors that are on lock position, like if(!connectorlocked){ block enforcement}? — Reply to this email directly or view it on GitHub.

togosh commented 9 years ago

Since we have to deal with the limitation at hand, what if we make that limitation not as harsh.

Interesting idea, give a user who goes over a block limit a message that they went over and they have 30-60 seconds (configurable) before it's enforced (so they have warning and time to fix it before removal). The interesting idea being giving them X time to fix it. On May 1, 2015 9:55 PM, "dodexahedron" notifications@github.com wrote:

Problem is that makes it an exploit. All someone ever has to do to get around the limit is build an extra reactor and a connector.

-----Original Message----- From: "Ragnar24" notifications@github.com Sent: ‎5/‎1/‎2015 8:29 PM To: "SEServerExtender/EssentialsPlugin" < EssentialsPlugin@noreply.github.com> Cc: "dodexahedron" brandon@dodecatec.com Subject: Re: [EssentialsPlugin] Block Enforcement - Grids connected byconnectors treated as one grid (#29)

This is just a quick thought, but might create other issues. What if the block enforcement ignored grids who has their connectors that are on lock position, like if(!connectorlocked){ block enforcement}? — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/SEServerExtender/EssentialsPlugin/issues/29#issuecomment-98299374 .

dodexahedron commented 9 years ago

An interesting thought. I'd of course make such a limit completely arbitrarily configurable (within the confines of how essentials works), but it's an interesting thought. One major potential problem is: what if they locked the connector from the control panel? They'd never see the chat message and would get a nasty surprise. Thoughts?

dodexahedron commented 9 years ago

Actually... Thinking about it... If I remember right (I'll have to look back at the code), enforcement just deletes the most recently added blocks from the offending grid. That could lead to very dire consequences for ships that dock, if true.