search

SEServerExtender / EssentialsPlugin

Dedicated Essentials Plugin
GNU Lesser General Public License v3.0
18 stars 18 forks source link

[SOLVED] (as best it can be for now) Most Large Grids not concealing #49

Closed FoxWyvern closed 8 years ago

FoxWyvern commented 9 years ago

Most Large Grids on my server are not concealing. Most of them being stations. Have no idea why, did a lot of testing and tried various blocks that might be preventing one station and/or ship being concealed while allowing others but to no avail.

FoxWyvern commented 9 years ago

Additionally, I have finally realized which grids won't conceal. It's any grid that has another entity attached either through a "LOCKED" Connector, Landing Gear, Rotor, or Piston. I believe one of my admins told me that Merge blocks were ok as they create a single entity when merged. Additionally, removing the head of a piston or rotor suddenly allows stations/ships to be concealed. I've also noticed that the /admin scan grids "hasdisplayname:DISPLAY NAME HERE" command does not owrk on any of these grids that have an attached entity. Has it always been this way or is this a more recent bug that hopefully can be fixed in the future?

dodexahedron commented 9 years ago

Good troubleshooting. I will have a look at this when I am home.

-----Original Message----- From: "FoxWyvern" notifications@github.com Sent: ‎6/‎12/‎2015 10:32 PM To: "SEServerExtender/EssentialsPlugin" EssentialsPlugin@noreply.github.com Subject: Re: [EssentialsPlugin] Most Large Grids not concealing (#49)

Additionally, I have finally realized which grids won't conceal. It's any grid that has another entity attached either through a "LOCKED" Connector, Landing Gear, Rotor, or Piston. I believe one of my admins told me that Merge blocks were ok as they create a single entity when merged. Additionally, removing the head of a piston or rotor suddenly allows stations/ships to be concealed. I've also noticed that the /admin scan grids "hasdisplayname:DISPLAY NAME HERE" command does not owrk on any of these grids that have an attached entity. Has it always been this way or is this a more recent bug that hopefully can be fixed in the future? — Reply to this email directly or view it on GitHub.

FoxWyvern commented 9 years ago

I want to say I'm no longer confident of Landing Gear preventing one or more grids from concealing. I honestly am not sure and wish I had done some additional testing. Due to work, I'll be unable to do any more additional testing for a few days, but I'll hopefully catch one of my admins and instruct them on some additional procedures for testing landing gear.

I can say for sure, that large grids that are properly concealing, will be prevented from concealing by adding a rotor with rotor top, and piston with piston top. As well as a connector being in the locked position. I believe this is also true for small grids as I had a newly made vehicle with rotors unable to conceal, but I didn't specifically go and test this by removing the pistons on the small ship.

I have not specifically gone through and removed existing rotors/pistons/locked connectors from stations already unable to conceal prior to my testing.

Additionally, /admin scan grids "hasdisplayname:DISPLAY NAME HERE" command was used without success on grids that could not already conceal prior to testing. I do not specifically remember attempting the command on a grid that I forced to be unable to conceal by adding a rotor or grid. I wish I had time to hop on for an hour or so to hammer these questions out to make them absolute but figured I'd at least mentioned what wasn't done so not to lead you astray.

Anyone else who reads this is also welcome to pick up my slack. I apologize, it was quite late when we were discovering this.

Tyrsis commented 9 years ago

If a ship is connected they will not be concealed. This is by design due to the fact that concealing connected ships used to cause run away memory leaks. Also if you conceal a ship that is connected via rotor or piston, the rotor head / piston head will disappear.

This is due to the fact that connections between grids can get complicated when the grids get renumbered (the connections are referenced by IDs, and when the IDs change without severing the connections, bad things happen).

FoxWyvern commented 9 years ago

Sad times, so many complex structures use pistons/rotors.. hopefully keen adjusts this in the near future but i won't hold my breath.