Closed markshowalter closed 5 months ago
Attention: Patch coverage is 34.31373%
with 67 lines
in your changes missing coverage. Please review.
Project coverage is 75.39%. Comparing base (
27afe87
) to head (ba9ff90
).
Files | Patch % | Lines |
---|---|---|
oops/gold_master/__init__.py | 34.09% | 52 Missing and 6 partials :warning: |
oops/config.py | 30.76% | 4 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Loosk good, all unit test pass. It looks like I miust have had some extraneous overrides in the galileo ssi standard_obs file.
In the third test, there were a bunch of Europa overrides, but they were applied to an Earth observation so they never got used. The Europa overrides were only needed for the fourth test.
This pull request contains fixes to how errors are logged. It was part of the previous pull request but that one got merged before I had pushed these changes.
In the LOGGING methods in
oops/config.py
:print()
, literal messages no longer get counted as warnings or errors, even if the level is WARN or ERROR. This is consistent with the point of literal messages, which is to add supplementary info to the log. Supplementary info about a warning or error should not increment the count.In
oops/gold_master/__init__.py
:define_standard_obs()
.LOGGING.pop()
is always called afterLOGGING.push()
using try/finally.For Galileo SSI:
define_standard_obs()
, taking advantage of the new input defaults.