SETI / rms-oops

Apache License 2.0
3 stars 0 forks source link

Cleanup of error logging in gold_master.py and Galileo SSI #132

Closed markshowalter closed 5 months ago

markshowalter commented 5 months ago

This pull request contains fixes to how errors are logged. It was part of the previous pull request but that one got merged before I had pushed these changes.

In the LOGGING methods in oops/config.py:

In oops/gold_master/__init__.py:

For Galileo SSI:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 34.31373% with 67 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (27afe87) to head (ba9ff90).

Files Patch % Lines
oops/gold_master/__init__.py 34.09% 52 Missing and 6 partials :warning:
oops/config.py 30.76% 4 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================== - Coverage 75.44% 75.39% -0.05% ========================================== Files 192 192 Lines 24078 24082 +4 Branches 2900 2906 +6 ========================================== - Hits 18165 18156 -9 - Misses 5079 5088 +9 - Partials 834 838 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

markshowalter commented 5 months ago

Loosk good, all unit test pass. It looks like I miust have had some extraneous overrides in the galileo ssi standard_obs file.

In the third test, there were a bunch of Europa overrides, but they were applied to an Earth observation so they never got used. The Europa overrides were only needed for the fourth test.