SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
9 stars 7 forks source link

Remove interval timer #1000

Closed rfrenchseti closed 4 years ago

rfrenchseti commented 4 years ago

Description of changes:

Removed 1 second interval timer and replaced with a single-shot timer that is started every time the user changes something related to search.

Known problems:

None

juzen2003 commented 4 years ago

Note: The change looks good, haven't found any bad behaviors yet. Just two minor things:

  1. Add some delay, like 3 seconds.
  2. Open up a RANGE or STRING widget, like the volume id widget (wait until everything is settled).
  3. In volume id, type something like "C" and leave focus.
  4. Before 1 second timer expires, quickly focus in the same input, remove "C" and focus out.
  5. A search will be performed (both result & widget spinner will be running, but result will not change because search selections are the same). Result spinner will only run if we try 3-4 the first time when a widget is open. Do we want to prevent result spinner from running in this case because search selections are the same? -> this is the 1st one.
  6. If we repeat 3-4 again, only the widget spinner will be running, but result spinner won't run (this is expected). Do we want to hide the widget spinner if no search is run? -> this is the 2nd one.
rfrenchseti commented 4 years ago

I fixed a few bugs I found in the existing code, include the two mentioned above: