SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
9 stars 7 forks source link

Dummy pull with notes on upgrading to Django 3.x #1104

Closed juzen2003 closed 3 years ago

juzen2003 commented 3 years ago
rfrenchseti commented 3 years ago

So based on your analysis and reading up on what they've changed, do you think it's worth upgrading to 3.x or is it OK to stay on 2 for now?

juzen2003 commented 3 years ago

I think it's ok for us to stay on Django 2.2 since it's still releasing new update (the latest 2.2.17 is expected to release on Nov). And at the same time we can wait for django_nose to release its new support on 3.1.x for the sql_flush, once it supports 3.1.x, we can upgrade to Django 3.1.x right away.

Note: To make django_nose sql_flush call work with Django 3.1.x, we can modify line 405 in runner.py (under site-pacakges/django_nose) by changing from: flush_statements = connection.ops.sql_flush(style, tables, connection.introspection.sequence_list()) to: flush_statements = connection.ops.sql_flush(style, tables) With above modification, python manage.py test will run and pass, runserver will work fine too.