SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
9 stars 7 forks source link

-implement the up/down keys for the gallery view/slide modal #1105

Closed dstopp closed 3 years ago

dstopp commented 3 years ago

Description of changes: -Catch the up and down arrows when the modal is open; in gallery view, the up/down will move the binoculars up or down one row and update the modal w/the new opusID; in table view, the up/down will do the same as next/prev and move one up or one down, then update the modal. -if there are no more rows up or down, the up/down arrow will do nothing.

Known problems:

juzen2003 commented 3 years ago
  1. In console, error message: metadataboxHtml: in each, observationData may be out of sync with colLabels;
    • Steps to reproduce the issue:
      1. Add some API delay.
      2. In gallery view, open up a metadata detail modal, and hold the down arrow key and it will move down to trigger initInfiniteScroll load.
      3. When spinner is still running, click edit in the modal and delete a metadata col. At the same time, keeping hitting down key maybe for about 3 to 4 times, then we can see the error message in the console. Most of the time, all metadata info will still be loaded fine, but sometimes it will have a blank right pane without any metadata info. Screen Shot 2020-11-04 at 7 06 24 AM Screen Shot 2020-11-04 at 7 59 28 AM
dstopp commented 3 years ago

re: 1. Binoculars stay on the gallery view after some changes in select metadata menu - that has been resolved.

re: 2. In console, error message: metadataboxHtml: in each, observationData may be out of sync with colLabels; This issue is in production code and is an unrelated bug. It is easy to dup in production code w/out any delays by using the table view, edit metadata, etc, similar as described above.