SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
10 stars 7 forks source link

Bootstrap 5 upgrade #1240

Closed dstopp closed 1 year ago

dstopp commented 2 years ago

Description of changes:

Known problems: The close button on the modal still needs some adjusting; testing of changes is ongoing. Testing still ongoing.

rfrenchseti commented 2 years ago

A few observations:

rfrenchseti commented 2 years ago
juzen2003 commented 2 years ago
rfrenchseti commented 2 years ago

If you activate the hamburger menu on an observation (like a thumbnail) and then select one of the menu items (like add to cart), an error shows up in the console.

dropdown.js:241 Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at li._isShown (dropdown.js:241:23)
    at li.toggle (dropdown.js:117:17)
    at HTMLAnchorElement.<anonymous> (dropdown.js:436:38)
    at HTMLDocument.n (event-handler.js:118:19)
rfrenchseti commented 2 years ago

If you create a download file from the cart page, the popup box that gives the list of URLs for downloads shows up where the mouse is, not in the lower right. If you close it and try to reopen it, it won't stay open and the spinning-busy-symbol is shown in the box for the brief time you can see it.

rfrenchseti commented 1 year ago

When in the table view, if you delete a column by clicking on the trashcan icon you get the following in the console:

Uncaught TypeError: this._menu is null _isShown dropdown.js:241 toggle dropdown.js:117

dropdown.js:436 n event-handler.js:118
rfrenchseti commented 1 year ago

This is actually a problem in the production OPUS too: If the "Download Links History" box is open, and the browser is shrunk very small, the footer goes away. But when it goes away, that links history box becomes detached from the footer area and shows up in the top left, partially off the screen.