SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
9 stars 7 forks source link

Use PosixPath to parse a filename rather than a regexp #1357

Closed fyellin closed 2 months ago

fyellin commented 2 months ago

FIX #1352

Rewrite property volume_set to use PosixPath rather than a regexp. Code was failing because

  1. The regexp was bogus. [/$] doesn't mean what I intended it to mean
  2. The regexp couldn't handle hyphens and periods in the directory name
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a421cb8) to head (66c4b95). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1357 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 41 41 Lines 25001 25001 Branches 1217 1181 -36 ========================================= Hits 25001 25001 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.