845

871

864 883 - not yet complete

Includes minor back end changes: -modified reset to return total counts/recycle counts -added option to return all the download option columns including items in recycle bin Front end changes to #cart tab: -add recycle icon on obs image when observation in recycle bin -restore original edit ability on #cart tab, including ctrl-click and range options -change #cart add/remove icons and text to reflect remove/restore to recycle bin w/new icons in all places those icons appear, including the observation sliding menu, mini menu, gallery view and table view hover text. -in the table view, draw a green line through the observation to indicate in recycle bin -update the cart status badge to display on the number of items in the cart -move the download buttons to the download options panel -change the Empty Cart button to a nav option -Add to the nav line Empty Cart Recycle bin and Restore Recycle Bin to Cart w/badge showing number of items in the recycle bin -disable the Empty/Restore recycle bin nav items when there is nothing in the recycle bin -update the download options panel to reflect changes as observations are removed/restored to the cart, as well as the total size an total files counts -update Getting Started Guide

Additional changes: -added a border/shadow around the recycle and binoculars to make them stand out better; -made the cart border more defined by making rounded edges and thicker border

rfrenchseti commented 5 years ago

Also this test is failing:

File "/seti/src/debby-pds-opus/opus/application/test_api/test_cart_api.py", line 769, in test__api_cart_remove_one_download_recyclebin1

rfrenchseti commented 5 years ago

From the commit message:

-changed panel name "Download Options" to "Download Data" in all places including comments -fixed the formatting on the download data panel when collapsed/expanded -updated the heading for the "Download Data" panel -updated popup text for #cart tab -really dimmed the blue nav options when not available -removed Downloads/csv... file that was accidentally added -updated text in cart.html and base.html per comments -changed "your cart/recycle bin" text style to "the cart/recycle bin" text style including confirm diaglog -updated gettingstarted.html w/modified cart description of recycle bin

rfrenchseti commented 5 years ago

Updates to my comments above:

(NOT FIXED) Download data/options pane doesn't work when the browser is too short.
(FIXED) When browser is narrow and download options pane is a fly-out, the button is still labeled "Download Options". It needs to say something like "Download Data" to make it clear this is where you download the data.
(FIXED) When the download options pane is a fly-out, it doesn't have the same format as it does when it's permanent. There are no headings for "Download Data" or "Download Options". This is because in the original version we moved "Download Options" to the header, but I don't think that's sufficient anymore.
(FIXED) Likewise, when you narrow the browser, pop out the options pane, and then widen the browser so it becomes permanent, you don't get the same format as when it was permanent to start with.
(NOT FIXED) I'm having trouble reproducing it, but in one case of widening and narrowing the browser and popping out and hiding the download options pane, I got in a state where changing the contents of the cart no longer updated the product counts. In fact I've now gotten it to happen even without changing the browser size, just by moving between the browse results and cart tabs and adding and removing items. Aha I think I found a way to reproduce: Start with an empty cart, go to browse results, add an observation, go to cart, move the observation to the recycle bin, go to browse results, go to cart, move observation out of recycle bin. The product counts won't update.
(FIXED) When using range on cart, popup should stay "Move range to recycle bin" or "Restore range from recycle bin"
(TOO DIM) I find the three blue options in the nav bar really dim and hard to read. Also, since they're already dim, there's no indication when they are turned off because they don't dim further (unless you mouse over).
(THIS IS NOT RELATED TO THIS PULL) I think the new thicker selection rectangle screwed up the size of the thumbnails. Reflow in the gallery no longer works smoothly as you widen and narrow the browser.

rfrenchseti commented 5 years ago

We need to revisit responsiveness on the cart tab. Right now the breaks are at sort of weird places, and browser sizes only a few pixels apart given different layouts when they don't need to.

rfrenchseti commented 4 years ago

I think the confirm dialog for "Empty Cart" should say, if there are any observations in the recycle bin, "Remove all observations from the cart and the recycle bin?"

rfrenchseti commented 4 years ago

Updates to my comments above:

(PARTIALLY FIXED) Download data/options pane doesn't work when the browser is too short.
(DONE) I think the confirm dialog for "Empty Cart" should say, if there are any observations in the recycle bin, "Remove all observations from the cart and the recycle bin?"

rfrenchseti commented 4 years ago

If you add things to the cart, go to the cart tab, empty the cart, then go back to browse, those observations now have a restore-from-recycle icon in the toolbar.
If you empty the recycle bin but have observations left in the cart, then go to the browse tab, no observations have cart borders
If you restore the recycle bin to the cart, then go to the browse tab, ALL observations have cart borders.

rfrenchseti commented 4 years ago

When you change the status of a thumbnail, the new numbers in the download pane don't have commas in them.
The back end is treating "move to recycle bin" as an operation that should throw an error on too many items in the cart, but it should ignore that.

SETI / rms-opus

845 recycle bin functionality #892

845

871

864

883 - not yet complete