SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
10 stars 7 forks source link

Catch cases where unit conversion results in an overflow #951

Closed rfrenchseti closed 4 years ago

rfrenchseti commented 4 years ago

Previously if you selected ring radius units of "Rs" and entered "1e307", it would accept the value as valid, but then during search it would throw an error that wasn't caught by the UI, resulting in infinite spinners. Also if you then tried to change the units to something better, it would put "inf" in the input field.

Both of these cases are now fixed. The handling of bad units is still slightly weird, since it treats the "invalid" value as the starting value for the next unit conversion, but this doesn't seem particularly important and I don't know how we'd want it to work differently anyway.