search

SETI / rms-opus

PDS OPUS - Outer Planets Data Search Tool
Apache License 2.0
10 stars 7 forks source link

Select Metadata code needs cleanup #966

Closed rfrenchseti closed 4 years ago

rfrenchseti commented 4 years ago

selectMetadata.js has a render function that does things like create the perfect scrollbars and attached the show and hide event handlers. But the render function is called more than once, resulting in multiple scrollbars in memory and (previous) duplicate event handlers. The event handler problem was "fixed" in a recent pull by removing the old handlers first, but that's not a clean fix. The whole code needs to be reorganized and cleaned up.

rfrenchseti commented 4 years ago

As part of this, the Select Metadata dialog needs to be put on hold while we are waiting for an updated menu because of a new search. Right now you can see the old menu, start mucking with it, then the new menu arrives in the middle of your work and changes everything out from under you. There should just be a blank dialog and a "loading" icon while we're waiting for the new menu to come back.