Closed esimpsons3ti closed 1 month ago
Attention: Patch coverage is 94.73684%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 71.84%. Comparing base (
037d4f6
) to head (40ebf25
).
Files | Patch % | Lines |
---|---|---|
pds4indextools/pds4_create_xml_index.py | 94.73% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was planning on working on unit tests after this is resolved, anyway. I would like that to be a part of a different pull request.
Due to the use of
fnmatch
in thefilter_dict_by_glob_patterns
function, any use of**
was considered two separate*
, and not as the recursive wildcard**
. A new helper function has been added to simulate the "match zero or more directories" logic to the pattern matching function. I also fixed a unit test file to more accurately find the intended pattern, as well as fixed a typo in a docstring.Fixes #23